Refactor EKS Regions call to accommodate varying regions
Summary
When trying to integrate GitLab with an EKS via the UI, occasionally regions do not appear to load with the error: Could not load regions from your AWS account.
In one particular scenario, we determined that the client-side call was made to us-east-2
ec2 whereas they were located in us-east-1
.
Steps to reproduce
Assuming the above is correct, you simply need to be out of the us-east-2
region to be impacted.
See slack conversation for more details (internal only)
From @ealcantara:
The client uses us-east-2 as a default region. Once a region is selected in the dropdown, it uses the selected region for subsequent requests
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)
What is the current bug behavior?
(What actually happens)
When using a valid role and trying to integrate GitLab with an EKS via the UI, occasionally regions do not appear to load with the error: Could not load regions from your AWS account.
What is the expected correct behavior?
(What you should see instead)
The regions dropdown should be populated.
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
Also from Enrique:
I think we could also pass the region once the role that allows gitlab to create EKS clusters is created: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/create_cluster/eks_cluster/store/actions.js#L42 I think it is the simplest solution, and the backend may already provide the region