Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 55.2k
    • Issues 55.2k
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1.6k
    • Merge requests 1.6k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #216836
Closed
Open
Issue created May 06, 2020 by Eric Schurter@ericschurterDeveloper

Display non-markdown content in the WYSIWYG mode of the Static Site Editor

Problem to solve

Static site generators rely on markdown pages to organize content, but the content is almost never exclusively written in markdown. Many generators rely on additional markup to provide additional options not provided by Markdown and it is completely valid to write raw HTML alongside markdown content.

The problem is that when the Static Site Editor loads the markdown page contents, it expects to be able to render markdown into HTML for rich text formatting. If that content is not valid markdown, the editor can get tripped up and will attempt to format the code as standard paragraph content.

Intended users

  • Parker (Product Manager)
  • Presley (Product Designer)

User experience goal

A user of the WYSIWYG mode in the Static Site Editor should be able to visually distinguish between markdown content and any additional code or markup.

Proposal

When we load content into the WYSIWYG editor, we should identify any non-markdown content and visually treat it in a way that distinguishes it from the editable rich-text content.

Further details

  • This issue doesn't include the ability to edit non-markdown content. We can ship this first and then work on #216837 (closed)
  • This issue implies that front matter is already being excluded from the editor as defined in #216834 (closed)

Documentation

Availability & Testing

What does success look like, and how can we measure that?

Acceptance criteria

  1. All page content except front matter is represented in the WYSIWYG mode of the Static Site Editor
  2. A user can visually distinguish between editable markdown content and any additional, non-markdown content

TODO (implementation issues)

  • kramdown (#220340 (closed)) %13.1
  • HTML (#221078 (closed)) %13.2
    • Account for HTML comments too
  • embedded ruby (.erb) (#221079 (closed)) %13.2
  • Identifiers (#221082 (closed)) %13.2
  • Font Awesome (#221083 (closed)) %13.2 - This ends up needing to be accounted for in the HTML custom renderer so dashing vs. checking this off. I was wrong, we have inline uses of this.
Edited Jul 16, 2020 by Derek Knox
Assignee
Assign to
Time tracking