[:monaco_snippets] Enable Monaco as default editor for Snippets by default
What
Remove the :monaco_snippets
feature flag.
The feature flag has been enabled globally on gitlab.com at the end of %12.9 and was enabled during the whole %12.10 without any major issue. A couple of minor visual glitches were promptly fixed at the end of %12.9. So it is considered to be pretty safe to enable this feature by default.
Owners
- Team: Create::Editor (Frontend)
- Most appropriate slack channel to reach out to:
#g_create_editor
- Best individual to reach out to: @dmishunov
Expectations
### What are we expecting to happen?
When editing a snippet, the editor will be Monaco instead of ACE. Visually this will be reflected in:
- user's "Syntax highlighting theme" setting for the "Dark" theme will be considered in the editor
- syntax highlighting, in general, will be significantly improved
- syntax highlighting will be updated when the user changes the extension of the snippet file
What might happen if this goes wrong?
The editing of Snippets will be broken if the editor crashes
What can we monitor to detect problems with this?
https://app.periscopedata.com/app/gitlab/596308/Snippets---Create:Editor-GitLab.com-Product-Metrics
Roll Out Steps
-
Enable on staging -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour -
Coordinate a time to enable the flag with #production
and#g_delivery
on slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
-
Cross post chatops slack command to #support_gitlab-com
and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
/cc @phikai @rkuba @fjsanpedro
Edited by Denys Mishunov