LFS icon / flag / indicator / badge does not show in file listing unless vue_file_list flag explicitly disabled
Summary
Customer noticed on a call with GitLab engineers that LFS badge was no longer showing in file listings, which temporarily confused troubleshooting an issue. Customer was running 12.9.2.
workaround
- Set the feature flag explicitly true (it is currently implicitly true)
- Then set it false.
- Verify the setting, and then quit the console.
Setting it false is probably sufficient, but the author was unable to easily test this.
Feature.enable("vue_file_list")
Feature.disable("vue_file_list")
Feature.enabled?("vue_file_list")
quit
Expected output:
> Feature.enable("vue_file_list")
=> nil
> Feature.disable("vue_file_list")
=> nil
> Feature.enabled?("vue_file_list")
=> false
> quit
Steps to reproduce
@stanhu found a related feature flag
reproduced on: 12.9.2. Would expect similar behavious in 12.8, as that's when feature flag change was made.
Starting point: badges not showing.
The flag reports as:
irb(main):002:0> Feature.enabled?("vue_file_list")
=> false
Set the flag true:
irb(main):003:0> Feature.enable("vue_file_list")
=> nil
irb(main):004:0> Feature.enabled?("vue_file_list")
=> true
Badges not showing.
irb(main):006:0> Feature.enabled?("vue_file_list")
=> false
Badges now show.
Example Project
gitlab.com behaviour is a bit different, at this time. (12.10.0-pre f175c3a6)
Browse to 'assets' directory in test project
Click on a file, and it shows with the LFS badge.
Go back to the directory:
What is the current bug behavior?
LFS badges do not show in file listing.
What is the expected correct behavior?
LFS badges show.
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.5p114 Gem Version: 2.7.10 Bundler Version:1.17.3 Rake Version: 12.3.3 Redis Version: 5.0.7 Git Version: 2.24.1 Sidekiq Version:5.2.7 Go Version: unknown GitLab information Version: 12.9.2-ee Revision: 0ad76f4d374 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 11.7 URL: https://bprescott-gitlabtest-0.do.gitlap.com HTTP Clone URL: https://bprescott-gitlabtest-0.do.gitlap.com/some-group/some-project.git SSH Clone URL: git@bprescott-gitlabtest-0.do.gitlap.com:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 12.0.0 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 12.0.0 ? ... OK (12.0.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 2/1 ... yes 2/2 ... yes 2/3 ... yes 2/4 ... yes 2/6 ... yes 2/7 ... yes 4/8 ... yes 2/9 ... yes 2/10 ... yes 2/11 ... yes 2/12 ... yes 2/13 ... yes 2/14 ... yes 6/15 ... yes 6/16 ... yes 2/17 ... yes 7/18 ... yes 8/19 ... yes 8/20 ... yes 8/21 ... yes 4/22 ... yes 4/23 ... yes 2/24 ... yes 14/26 ... yes 14/27 ... yes 2/28 ... yes 2/29 ... yes 2/30 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.5) Git version >= 2.22.0 ? ... yes (2.24.1) Git user has default SSH configuration? ... yes Active users: ... 3 Is authorized keys file accessible? ... yes Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)