Skip to content

CI Yaml errors are rendered incorrectly when the error message has commas

In https://gitlab.com/gitlab-org/gitlab/blob/a66ceca300bd04152f83dc2246e406180f12e38c/app/views/projects/pipelines/show.html.haml#L15 we split by ,. But some error messages could contain commas resulting in those errors being rendered incorrectly like so:

image

This error message comes from https://gitlab.com/gitlab-org/gitlab/blob/d318aabd26db5a100c35df92417f210705630c66/lib/gitlab/ci/yaml_processor.rb#L160 where we list the possible stage values in the error message.

cc @jyavorska @marcel.amirault

Edited by Heinrich Lee Yu