In a MR, "Please resolve these threads" should be a hyperlink pointing to the threads to be resolved.
Once there are discussions on an MR (comments to comments), The MR button is greyed out and a div with text ("There are unresolved threads. Please resolve these threads") and a button ("Create an issue to resolve them later") appears. But there are no (visual) cues as to where or what those threads are.
In a MR, "Please resolve these threads" should be a hyperlink pointing to the threads to be resolved.
Proposal
- Add the “Jump to first unresolved thread” button next to the “Create issue…” button and turn them into a button group. They should have icons to make the association stronger.
- Change the “Create issue…” label to
Resolve all threads in new issue
(yes, the screenshot below has a different button label, disregard that button label). - Change the “can't merge” messaging to be less about “you” and more generic. This is because the current user may not have permissions to merge. Also, they might not have permissions to resolve them
😬 We would tweak it as:Before this can be merged, 2 threads must be resolved.
Edited by Pedro Moreira da Silva