Merge Request process breaks if an integration endpoint is unreachable

Summary

As far as I can tell, this is not a duplicate. We recently changed the domain name of our JIRA on-prem Server. Following this change, the merge requests in our projects generated multiple merge commits on the target branch, and their status would not change to merged. Apparently, the JIRA integration breaks the merge request process if the JIRA endpoint is not reachable.

Steps to reproduce

  • Enable JIRA integration on a project with a domain.
  • Change JIRA's domain name.
  • This results in JIRA's integration targeting a unreachable domain.
  • Create a MR.
  • Try to merge it.
  • This will result in four merge commits on the target branch, and the status of the MR will not change.

What is the current bug behavior?

GitLab breaks on the MR validation process.

What is the expected correct behavior?

GitLab should not break the MR validation if JIRA or any integration endpoint is unreachable.

Possible fixes

I do not have any code to share just yet. But adding a condition in the Merge Request validation process that would bypass the integration webhooks if the endpoint is unreachable or not responding.

Edited Mar 14, 2018 by Kappalys Bot
Assignee Loading
Time tracking Loading