Smoke test failure in qa/specs/features/browser_ui/4_verify/ci_variable/add_remove_ci_variable_spec.rb:46
This is failing in:
- found:master https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/jobs/517786228
- found:pre.gitlab.com https://ops.gitlab.net/gitlab-org/quality/preprod/-/jobs/1097907
- found:staging.gitlab.com https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/1100089
- found:nightly https://gitlab.com/gitlab-org/quality/nightly/-/jobs/517346465
From https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/1100089:
Failures:
1) Verify Add or Remove CI variable via UI user adds a CI variable
Failure/Error:
Resource::CiVariable.fabricate_via_browser_ui! do |ci_variable|
ci_variable.project = project
ci_variable.key = 'VARIABLE_KEY'
ci_variable.value = 'some_CI_variable'
ci_variable.masked = false
end
Capybara::ElementNotFound:
Unable to find css "[data-qa-selector=\"ci_variable_key_field\"],.qa-ci-variable-key-field" within #<Capybara::Node::Element tag="section" path="/HTML/BODY[1]/DIV[1]/DIV[2]/DIV[3]/DIV[1]/SECTION[5]">
# /usr/local/bundle/gems/capybara-3.29.0/lib/capybara/node/finders.rb:296:in `block in synced_resolve'
# /usr/local/bundle/gems/capybara-3.29.0/lib/capybara/node/base.rb:83:in `synchronize'
# /usr/local/bundle/gems/capybara-3.29.0/lib/capybara/node/finders.rb:287:in `synced_resolve'
# /usr/local/bundle/gems/capybara-3.29.0/lib/capybara/node/finders.rb:52:in `find'
# /usr/local/bundle/gems/capybara-3.29.0/lib/capybara/session.rb:749:in `block (2 levels) in <class:Session>'
# /usr/local/bundle/gems/capybara-3.29.0/lib/capybara/dsl.rb:51:in `block (2 levels) in <module:DSL>'
# ./qa/page/base.rb:102:in `find_element'
# ./qa/support/page/logging.rb:38:in `find_element'
# ./qa/page/base.rb:142:in `fill_element'
# ./qa/support/page/logging.rb:82:in `fill_element'
# ./qa/page/project/settings/ci_variables.rb:26:in `fill_variable'
# ./qa/resource/ci_variable.rb:23:in `block (2 levels) in fabricate!'
# ./qa/scenario/actable.rb:16:in `perform'
# ./qa/page/project/settings/ci_cd.rb:44:in `block in expand_ci_variables'
# ./qa/page/settings/common.rb:20:in `block in expand_section'
# ./qa/page/base.rb:252:in `block in within_element'
# /usr/local/bundle/gems/capybara-3.29.0/lib/capybara/session.rb:343:in `within'
# ./qa/page/base.rb:251:in `within_element'
# ./qa/support/page/logging.rb:143:in `within_element'
# ./qa/page/settings/common.rb:11:in `expand_section'
# ./qa/page/project/settings/ci_cd.rb:43:in `expand_ci_variables'
# ./qa/resource/ci_variable.rb:21:in `block in fabricate!'
# ./qa/scenario/actable.rb:16:in `perform'
# ./qa/resource/ci_variable.rb:20:in `fabricate!'
# ./qa/resource/base.rb:30:in `block (2 levels) in fabricate_via_browser_ui!'
# ./qa/resource/base.rb:135:in `log_fabrication'
# ./qa/resource/base.rb:30:in `block in fabricate_via_browser_ui!'
# ./qa/resource/base.rb:118:in `do_fabricate!'
# ./qa/resource/base.rb:29:in `fabricate_via_browser_ui!'
# ./qa/specs/features/browser_ui/4_verify/ci_variable/add_remove_ci_variable_spec.rb:46:in `add_ci_variable'
# ./qa/specs/features/browser_ui/4_verify/ci_variable/add_remove_ci_variable_spec.rb:15:in `block (3 levels) in <module:QA>'
# /usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:123:in `block in run'
# /usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `loop'
# /usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `run'
# /usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
# ./spec/spec_helper.rb:69:in `block (2 levels) in <top (required)>'
# /usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:123:in `block in run'
# /usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `loop'
# /usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `run'
# /usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
# /usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:37:in `block (2 levels) in setup'
# ./qa/specs/runner.rb:69:in `perform'
# ./qa/scenario/template.rb:10:in `block in perform'
# ./qa/scenario/template.rb:8:in `tap'
# ./qa/scenario/template.rb:8:in `perform'
# ./qa/scenario/template.rb:33:in `perform'
# ./qa/scenario/template.rb:10:in `block in perform'
# ./qa/scenario/template.rb:8:in `tap'
# ./qa/scenario/template.rb:8:in `perform'
# ./qa/scenario/bootable.rb:28:in `launch!'
I think it's failing because the QA selector is expecting ci-variable-key-field
instead of variable-key
:
I believe this was introduced in 6a9a5d77.
Untested fix:
diff --git a/app/assets/javascripts/ci_variable_list/components/ci_key_field.vue b/app/assets/javascripts/ci_variable_list/components/ci_key_field.vue
index 1dc71acdf7b..f5c2cc57f3f 100644
--- a/app/assets/javascripts/ci_variable_list/components/ci_key_field.vue
+++ b/app/assets/javascripts/ci_variable_list/components/ci_key_field.vue
@@ -132,7 +132,7 @@ export default {
aria-controls="token-suggestions"
aria-haspopup="listbox"
:aria-expanded="showSuggestions"
- data-qa-selector="variable_key"
+ data-qa-selector="ci_variable_key_field"
@input="onEntry"
@keydown.down="onArrowDown"
@keydown.up="onArrowUp"
/cc: @sarahghp
Edited by Mark Lapierre