Remove remaining RuboCop offenses for `Cop/InjectEnterpriseEditionModule`
Mantra
New code should not contain any offenses but let's also take care of the old code, shall we?
Problem
In !9189 (22819272) we've whitelisted all EE offenses for Cop/InjectEnterpriseEditionModule
.
Proposed solution
- Move
prepend_if_ee
to the last line of each file as suggested in https://docs.gitlab.com/ee/development/ee_features.html#ee-features-based-on-ce-features - Remove
# rubocop: disable Cop/InjectEnterpriseEditionModule
- Make sure the specs are
💚 - Submit MR (see
Remaining Offenses
section👇 )
Remaining offenses
Occurrences left/total: 50/96
rg -l "Cop/InjectEnterpriseEditionModule" | wc -l
Full listing
app/graphql/gitlab_schema.rb
app/helpers/application_settings_helper.rb
app/helpers/auth_helper.rb
app/helpers/form_helper.rb
app/helpers/projects_helper.rb
app/helpers/services_helper.rb
app/helpers/sorting_helper.rb
app/helpers/system_note_helper.rb
app/models/commit_status.rb
app/models/concerns/noteable.rb
app/models/concerns/protected_ref_access.rb
app/models/discussion_note.rb
app/models/global_milestone.rb
app/models/group_milestone.rb
app/models/list.rb
app/models/members_preloader.rb
app/models/milestone.rb
app/models/project_authorization.rb
app/models/project_import_data.rb
app/models/project_services/chat_message/merge_message.rb
config/initializers/rack_attack_new.rb
ee/app/controllers/ee/confirmations_controller.rb
ee/app/models/ee/project.rb
ee/app/presenters/ee/merge_request_presenter.rb
ee/app/serializers/vulnerabilities/finding_entity.rb
ee/app/services/concerns/approval_rules/updater.rb
ee/app/services/ee/emails/create_service.rb
ee/app/services/ee/emails/destroy_service.rb
ee/app/services/ee/quick_actions/interpret_service.rb
ee/app/services/ee/system_note_service.rb
ee/app/services/ee/users/update_service.rb
ee/lib/ee/api/boards.rb
ee/lib/ee/api/group_boards.rb
ee/lib/ee/api/group_milestones.rb
ee/lib/ee/api/project_milestones.rb
ee/lib/ee/gitlab/geo_git_access.rb
lib/api/api_guard.rb
lib/api/boards.rb
lib/api/group_boards.rb
lib/api/group_clusters.rb
lib/api/helpers/project_snapshots_helpers.rb
lib/api/helpers/runner.rb
lib/api/job_artifacts.rb
lib/api/merge_requests.rb
lib/api/namespaces.rb
lib/api/project_clusters.rb
lib/feature.rb
lib/gitlab/auth.rb
lib/gitlab/import_sources.rb
Please go ahead, grab a directory/file, open an MR, and try to move prepend_if_ee
to the last line:
-
!29248 (merged) - lib/banzai
(6 offenses) -
!29274 (merged) - app/finders
(3 offenses) -
!29326 (closed) - app/graphql
(1 offense) -
!29327 (merged) - app/helpers
(8 offenses) -
!29328 (merged) - app/presenters
(1 offense) -
!29332 (merged) - app/serializers
(3 offenses) -
!29379 (merged) - app/{uploaders,workers}
(3 offenses) -
!29938 (merged) !30070 (merged) !30194 (merged) !30289 (merged) !30291 (merged) - lib/gitlab
-
!30425 (merged) - ee/app/services
-
MR link - directory/file
Update Occurrences
counter above.
Edited by Peter Leitzen