API to rollout Elasticsearch to percentage of namespaces uses stale cache and does not index anything
Summary
Noticed in gitlab-com/gl-infra/production#1788 (comment 319610320) the API to rollout namespaces by percentages https://gitlab.com/gitlab-org/gitlab/-/blob/3583bcf56d2555c12ebde9d0aef686f80a73487f/ee/lib/api/elasticsearch_indexed_namespaces.rb does not actually trigger any projects to be indexed due to a stale cache.
This is due to https://gitlab.com/gitlab-org/gitlab/-/blob/3583bcf56d2555c12ebde9d0aef686f80a73487f/ee/app/models/elasticsearch_indexed_namespace.rb#L53 using Gitlab::Database.bulk_insert
which is not triggering the after_commit
behaviour introduced in !27348 (diffs) at https://gitlab.com/gitlab-org/gitlab/-/blob/3583bcf56d2555c12ebde9d0aef686f80a73487f/ee/app/models/concerns/elasticsearch_indexed_container.rb#L11 .
Steps to reproduce
- Prime the cache by asking
Project#use_elasticsearch?
on any project - Invoke this API https://gitlab.com/gitlab-org/gitlab/-/blob/3583bcf56d2555c12ebde9d0aef686f80a73487f/ee/lib/api/elasticsearch_indexed_namespaces.rb
- Confirm that nothing new was indexed in Elasticsearch
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)
What is the current bug behavior?
(What actually happens)
What is the expected correct behavior?
(What you should see instead)
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)