Failure in `qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb` expected #has_vulnerability?("Prototype pollution attack in mixin-deep") to return true, got false
Summary
/qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb
fails on trying to find a vulnerability name
expected #has_vulnerability?("Prototype pollution attack in mixin-deep") to return true, got false
It looks like something has changed where it appears that where we previously had a QA selector:
<div data-v-866fb6b8="" data-qa-selector="vulnerability_info_content" class="table-mobile-content vulnerability-info"><button data-v-866fb6b8="" type="button" class="btn vulnerability-title d-inline btn-blank btn-md"><!----> Prototype pollution attack in mixin-deep</button> <!----> <!----> <br data-v-866fb6b8=""> <span data-v-866fb6b8="" class="vulnerability-namespace"> package.json </span></div>
We no longer do:
<a href="/gitlab-qa-sandbox-group/qa-test-2020-04-07-14-43-56-190bd7844b2a9818/project-with-secure-5ac52db8a0e0e7da/-/security/vulnerabilities/21305" class="gl-link text-body js-description"> Prototype pollution attack in mixin-deep </a>
Stack trace
1) Secure Security Reports displays security reports in the project security dashboard
Failure/Error: expect(dashboard).to have_vulnerability dependency_scan_example_vuln
expected #has_vulnerability?("Prototype pollution attack in mixin-deep") to return true, got false
# ./qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb:83:in `block (5 levels) in <module:QA>'
# ./qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb:139:in `filter_report_and_perform'
# ./qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb:82:in `block (4 levels) in <module:QA>'
# ./qa/scenario/actable.rb:16:in `perform'
# ./qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb:81:in `block (3 levels) in <module:QA>'
# /Users/willmeek/.rvm/gems/ruby-2.6.5/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:123:in `block in run'
# /Users/willmeek/.rvm/gems/ruby-2.6.5/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `loop'
# /Users/willmeek/.rvm/gems/ruby-2.6.5/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `run'
# /Users/willmeek/.rvm/gems/ruby-2.6.5/gems/rspec-retry-0.6.1/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
# /Users/willmeek/.rvm/gems/ruby-2.6.5/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:37:in `block (2 levels) in setup'
# ./qa/specs/runner.rb:69:in `perform'
# ./qa/scenario/template.rb:10:in `block in perform'
# ./qa/scenario/template.rb:8:in `tap'
# ./qa/scenario/template.rb:8:in `perform'
# ./qa/scenario/template.rb:33:in `perform'
# ./qa/scenario/template.rb:10:in `block in perform'
# ./qa/scenario/template.rb:8:in `tap'
# ./qa/scenario/template.rb:8:in `perform'
# ./qa/scenario/bootable.rb:28:in `launch!'
Screenshot / HTML page
secure_security_reports_displays_security_reports_in_the_project_security_dashboard.html
Possible fixes
Add data-qa-selector="vulnerability_info_content"
back to the element?
/due in 2 weeks
Stage expect(dashboard).to have_vulnerability dependency_scan_example_vuln
for /qa/specs/features/ee/browser_ui/secure/security_reports_spec.rb