Skip to content

Remove excessive .dropdown-toggle styling from dropdowns.scss

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

In order to deliver #204730 (closed) we have to put specific style into app/assets/stylesheets/framework/dropdowns.scss:

.dropdown.gl-new-dropdown button.dropdown-toggle {
  @include gl-display-inline-flex;
}

This is a temporary solution in anticipation of the new design for Snippets to be implemented in which the dropdown button will be moved out of .file-title-flex-parent that is the core of the problem for introducing this style in the first place.

Improvements

Once the dropdown button is moved out of .file-title-flex-parent, we can safely remove this style.

Risks

No risks as the styles are dedicated to one specific component that, after the design update, won't be covered by this style.

Involved components

  • The affected stylesheet: app/assets/stylesheets/framework/dropdowns.scss
  • The affected components:
    • app/assets/javascripts/vue_shared/components/clone_dropdown.vue, and its parent
    • app/assets/javascripts/snippets/components/snippet_blob_view.vue
Edited by 🤖 GitLab Bot 🤖