Rename `with_attachment` to `failed_with_attachment` for clarity
I noticed this, and it may be slightly confusing and may warrant a refactor.
The following discussion from !28571 (merged) should be addressed:
-
@cablett started a discussion: Not within the scope of your MR, but it's curious why this is
with_attachment
and notfailed_with_attachment
🤔
Edited by Max Orefice