Emojis in commits do not always display
Summary
Some pages show emojis in commits and some do not.
Steps to reproduce
- Commit with an emoji in the message
- Check out different places where you can see commit messages
Example Project
-
Emoji is not displayed when you hover over 3.
What is the current bug behavior?
Emoji displays as text on some pages
What is the expected correct behavior?
Emoji should be displayed as a picture / etc
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- misticos changed the description
Compare with previous version changed the description
We have started adopting gitmoji and noticed they aren't displaying in commits on the project overview / files pages either. Does this require a separate issue?
Here's what it looks like in GitHub: https://github.com/tiangolo/fastapi
Here's what it looks like in GitLab: https://gitlab.com/jorgerpo/fastapi
Edited by Mike HeynsCollapse replies - Developer
@mheynz It seems like this is the same issue
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#32 (closed)
mentioned in issue gitlab-org/quality/triage-reports#32 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#33 (closed)
mentioned in issue gitlab-org/quality/triage-reports#33 (closed)
- Tiffany Rea added devopscreate emoji groupsource code severity4 typebug labels
added devopscreate emoji groupsource code severity4 typebug labels
- Tiffany Rea added Category:Source Code Management label
added Category:Source Code Management label
- 🤖 GitLab Bot 🤖 mentioned in issue #214178 (closed)
mentioned in issue #214178 (closed)
- Michelle Gill added [deprecated] Accepting merge requests [deprecated] 🍎 frontend priority4 + 1 deleted label
added [deprecated] Accepting merge requests [deprecated] 🍎 frontend priority4 + 1 deleted label
- Michelle Gill changed milestone to %Backlog
changed milestone to %Backlog
- Developer
Looks like this is just a difference in how the frontend renders the various
/commits
files: https://gitlab.com/gitlab-org/gitlab/-/tree/master/app/views/projects/commits - Michelle Gill marked #207040 (closed) as a duplicate of this issue
marked #207040 (closed) as a duplicate of this issue
- Michelle Gill marked this issue as related to #207040 (closed)
marked this issue as related to #207040 (closed)
- Developer
This may be a regression from &159 (closed)
- Michelle Gill added regression regression:12.9 labels
added regression regression:12.9 labels
- Quentin LAURENT mentioned in issue #215968 (closed)
mentioned in issue #215968 (closed)
Problem is solved for me for now!
I'll keep this issue open for now because I have some questions whether this is related to the
vue_file_list
feature flag: #215968 (comment 336249443)- Phil Hughes assigned to @iamphill
assigned to @iamphill
The bug is back for me...
Collapse replies - Maintainer
@Torvald Sorry the feature flag was turned back on - i will switch it off until this is fixed!
- Phil Hughes mentioned in commit cb632e31
mentioned in commit cb632e31
- Phil Hughes mentioned in merge request !31070 (merged)
mentioned in merge request !31070 (merged)
- Phil Hughes mentioned in commit b8e6a473
mentioned in commit b8e6a473
- Phil Hughes mentioned in commit 20cfd44c
mentioned in commit 20cfd44c
- Phil Hughes mentioned in commit 3b04c033
mentioned in commit 3b04c033
- Phil Hughes mentioned in commit cd1994c1
mentioned in commit cd1994c1
- Heinrich Lee Yu closed via merge request !31070 (merged)
closed via merge request !31070 (merged)
- Heinrich Lee Yu mentioned in commit aa98caf9
mentioned in commit aa98caf9
- Ray Paik added [deprecated] good for new contributors label
added [deprecated] good for new contributors label
- Katrin Leinweber mentioned in issue #241495 (closed)
mentioned in issue #241495 (closed)