Consider faster deployment strategy for review app deployment

Currently the review app deployments are configured with the default deployment strategy:

StrategyType:           RollingUpdate
MinReadySeconds:        0
RollingUpdateStrategy:  25% max unavailable, 25% max surge

This would add up to the total time taken to complete a deployment in an upgrade scenario where there is an existing deployment.

The reason is that pods are spun up and taken off one by one, and each one could take a few minutes to complete.

Examples:

  • https://gitlab.com/gitlab-org/gitlab/-/jobs/486324551

Since review app is not bearing production load, we can consider quicker deployment strategy. The options are (from most aggressive to least aggresive):

  • Change to .spec.strategy.type==Recreate - this kills all pods and replace them with new ones immediately
  • Increase .spec.strategy.rollingUpdate.maxUnavailable from default 25% to 50%.
Edited Mar 27, 2020 by Albert Salim
Assignee Loading
Time tracking Loading