Fix RSpec/RepeatedExample offenses
In !28090 (merged) we've enabled RSpec/RepeatedExample
.
This cop checks for repeated examples within example groups. The following files contain duplicated examples:
-
!28860 (merged) - spec/features/issues/filtered_search/filter_issues_spec.rb -
!28859 (merged) - spec/features/merge_request/user_posts_diff_notes_spec.rb -
!28858 (merged) - spec/features/projects/files/template_type_dropdown_spec.rb -
!28857 (merged) - spec/finders/environments_finder_spec.rb -
!28856 (merged) - spec/frontend/fixtures/merge_requests.rb -
!28855 (merged) - spec/graphql/gitlab_schema_spec.rb -
!28854 (merged) - spec/helpers/users_helper_spec.rb -
!28607 (merged) - spec/lib/banzai/filter/autolink_filter_spec.rb -
!28612 (merged) - spec/lib/banzai/filter/issuable_state_filter_spec.rb -
!28803 (merged) - spec/lib/gitlab/closing_issue_extractor_spec.rb -
!28801 (merged) - spec/lib/gitlab/danger/changelog_spec.rb -
!28639 (merged) - spec/lib/gitlab/git/blob_spec.rb -
!28794 (merged) - spec/lib/gitlab/import_export/project/relation_factory_spec.rb -
!28644 (merged) - spec/models/ability_spec.rb -
!28633 (merged) - spec/models/ci/build_spec.rb -
!28632 (merged) - spec/models/concerns/issuable_spec.rb -
!28368 (merged) - spec/models/concerns/prometheus_adapter_spec.rb -
!28574 (merged) - spec/models/member_spec.rb -
!28664 (merged) - spec/models/project_services/chat_message/pipeline_message_spec.rb -
!28450 (merged) - spec/models/user_spec.rb -
!28551 (merged) - spec/models/wiki_page_spec.rb -
!28403 (merged) - spec/requests/api/merge_requests_spec.rb -
!28790 (merged) - spec/routing/admin_routing_spec.rb -
!28787 (merged) - spec/rubocop/cop/migration/update_large_table_spec.rb -
!28742 (merged) - spec/services/notification_service_spec.rb -
!28669 (merged) - spec/services/web_hook_service_spec.rb -
!28538 (merged) - ee/spec/models/group_spec.rb -
!28513 (merged) - ee/spec/models/user_spec.rb -
!28403 (merged) - ee/spec/requests/api/merge_request_approvals_spec.rb -
!28650 (merged) - ee/spec/services/boards/lists/update_service_spec.rb -
!28525 (merged) - ee/spec/services/geo/repository_verification_primary_service_spec.rb -
!28409 (merged) - ee/spec/workers/geo/file_download_dispatch_worker_spec.rb
Each case should be tackled individually because in one case it can be simply a duplicated piece code, while in another one it can be a missed scenario
Edited by Peter Leitzen