Specs no longer can spawn Gitaly
GDK specs are now failing locally on master
:
$ bundle exec rspec spec/models/project_spec.rb
Run options: include {:focus=>true}
All examples were filtered out; ignoring {:focus=>true}
==> Setting up Gitaly...
Checking gitaly-ruby Gemfile...
Checking gitaly-ruby bundle...
The Gemfile's dependencies are satisfied
Trying to connect to gitaly: ........ OK
Trying to connect to praefect: OK
Gitaly set up in 11.501971 seconds...
An error occurred in a `before(:suite)` hook.
Failure/Error: raise "could not connect to #{service} at #{socket.inspect} after #{sleep_time} seconds"
RuntimeError:
could not connect to gitaly at "/Users/stanhu/gitlab/gdk-ee/gitlab/tmp/tests/gitaly/gitaly.socket" after 10 seconds
# ./spec/support/helpers/test_env.rb:236:in `wait'
# ./spec/support/helpers/test_env.rb:202:in `start_gitaly'
# ./spec/support/helpers/test_env.rb:168:in `block in setup_gitaly'
# ./spec/support/helpers/test_env.rb:476:in `component_timed_setup'
# ./spec/support/helpers/test_env.rb:162:in `setup_gitaly'
# ./spec/support/helpers/test_env.rb:110:in `init'
# ./ee/spec/support/helpers/ee/test_env.rb:6:in `init'
# ./spec/spec_helper.rb:149:in `block (2 levels) in <top (required)>'
Now that be578468 has been merged, we now have two UNIX sockets:
-
tmp/tests/gitaly/gitaly.socket
for Gitaly -
tmp/tests/gitaly/praefect.socket
for Praefect
The problem is that most GDK gitlab.yml
configs are used to talk to tmp/tests/gitaly/praefect.socket
, so that's what the test Gitaly server uses to start up.
However, https://gitlab.com/gitlab-org/gitlab/blob/be5784685583dffebc9f41f00500fa4ed6063d5c/spec/support/helpers/test_env.rb#L201 attempts to talk to that Gitaly server but fails.
Edited by Stan Hu