Skip to content

Move features to core: Code Quality MR Widget

Problem to solve

Teams want to contribute to Code Quality features but with the majority of the feature set being in the GitLab Starter tier they are not incentivized to do so. As such there have been no community contributions.

Intended users

Further details

As noted in the blog post features are priced to the user most likely to be a champion for the feature. As we think about the features in the Code Quality feature it is clear that the MR widget that details improvements and degradations in code quality associated with the merge are likely to be used and championed by the individual user. As such this feature belongs in the ~"Category:DevOps Score" tier.

Proposal

Move the MR Widget functionality from the GitLab Starter to the GitLab Core tier. Leave the Full Code Quality report in the GitLab Starter tier.

Only the frontend code needs to be moved for this.

  1. Create a app/assets/javascripts/reports/code_quality folder to contain the core code quality.
  2. Create a code_quality_report.vue file in the above directory. In this file we will render the <report-section> that is found in the mr_widget_options file.
  3. Create a store to fetch the code quality reports for the base path and head path, which we will pass into the component from the core mr_widget_options component.
  4. Add the comparison to the store which currently exists in the mr_widget_store.
  5. Create the specs for the new code_quality_report.vue and store.
  6. Remove the specs from the mr_widget_store_spec.

Permissions and Security

Documentation

Update the Code Quality Documentation to better explain what parts of this feature are in each tier.

Availability & Testing

Risk for activity like this is typically centered around authorization, however since this feature is being moved to core and thus available to every user, risk in this area is minimal.

  • movement and execution of the existing unit tests should be sufficient
  • package-and-qa is not required

What does success look like, and how can we measure that?

Users of GitLab free can see the Code Quality MR Widget after this change is live.

What is the type of buyer?

See the Proposal above, this is moving to GitLab Core

Is this a cross-stage feature?

No.

Links / references

Edited by Zeff Morgan