License Compliance - There are still some user facing text references to "Appoved" and "Blacklisted"
In a recent License Compliance air gap demo I noticed there were still a few locations where we use the terminology "Approved" and "Blacklisted".
We should circle back and cleanup those references. They should be:
Action:
"Approve" -> "Allow"
"Blacklist" -> "Deny"
State:
"Approved" -> "Allowed"
"Blacklisted" -> "Denied"
Development Notes:
The modal visible from the "Security" tab on the pipeline page still showed "Approve" / "Blacklist"
Locations:
ee/app/views/projects/settings/ci_cd/_managed_licenses.html.haml qa/qa/specs/features/ee/browser_ui/secure/merge_request_license_widget_spec.rb qa/qa/ee/page/merge_request/show.rb qa/qa/ee/page/component/license_management.rb ee/lib/api/managed_licenses.rb ee/app/assets/javascripts/vue_shared/license_compliance/components/add_license_form.vue ee/app/assets/javascripts/approvals/constants.js
Questions:
ee/lib/api/managed_licenses.rb
So we don't break the API and cause backwards incompatibility is it ok to change things like
params do
requires :name, type: String, desc: 'The name of the license'
requires :approval_status,
type: String,
values: %w(approved blacklisted),
desc: 'The approval status of the license. "blacklisted" or "approved".'
end
Testing
SET to ensure test assets have these terms updated
qa/qa/specs/features/ee/browser_ui/secure/merge_request_license_widget_spec.rb
qa/qa/ee/page/merge_request/show.rb
qa/qa/ee/page/component/license_management.rb