Skip to content

test suite report screen scroll is buggy, making individual tests unreadable

Summary

EE client here. We are using the Junit XML test reporting on our pipeline to show the test results within Gitlab. With our current set up these generate stacktraces on errors, that show up when clicking on the test suite to see the individual test results.

We have a reasonable amount of tests, hundreds, so the list scrolls. However, there is some javascript around the scrollable window that does not work properly, so we cannot properly read the tests.

As on GitLab Enterprise Edition 12.7.6-ee

Steps to reproduce

Run a pipeline with a large amount of tests, that also has some errors. upon completion, check the pipeline page, go to tests, and click on the test suite. Try to scroll through this list of individual test results.

Example Project

https://gitlab.com/ethan.reesor/contrib/gitlab-272274/pipelines/142035286/test_report

What is the current bug behavior?

scrolling through the list of individual test results, the scrolling jumps unexpectedly over some parts of the scroll area.

Screen_Recording_2020-02-21_at_9.46.32_AM

What is the expected correct behavior?

I can neatly scroll through the test results list, reading each test result with all info that goes with it.

Relevant logs and/or screenshots

To be exactly clear, this is the feature: https://docs.gitlab.com/ee/ci/junit_test_reports.html

Output of checks

As on GitLab Enterprise Edition 12.7.6-ee

Results of GitLab environment info

I have no access to this.

Expand for output related to GitLab environment info 

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

I have no access to this.

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

This janky/jumpy/buggy scrolling seems to happen because some javascript tries to minimize the number of test results in the DOM. When I see the scroll becoming janky, I see removal/change of DOM content in firefox devtools.

This code might have some assumption on how many pixels of height each test result has, which is wrong for test results with long names and/or error results such as stack traces?

Edited by James Heimbuck