Move convenience methods for labels into Danger helper
Summary
Follow up issue from review comment
Improvements
This methods could be useful in other use cases
def has_label?(label)
gitlab.mr_labels.include?(label)
end
def add_labels_to_merge_request(labels)
gitlab.api.update_merge_request(gitlab.mr_json['project_id'],
gitlab.mr_json['iid'],
labels: (gitlab.mr_labels + labels).join(','))
end
https://gitlab.com/gitlab-org/gitlab/-/blob/master/danger/telemetry/Dangerfile
We could move them in the helper file
https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/danger/helper.rb
Risks
Danger bot could break, add tests to cover the change to prevent this
Involved components
Danger bot
Optional: Intended side effects
Optional: Missing test coverage
Edited by Mark Fletcher