GitLab does not upgrade from 12.8.7 to 12.9

I checked:

my case it not shown for the period of last 2 days, because Gitlab 12.9 was released today.

Summary

When upgrading GitLab-EE 12.8.7 to 12.9 on Debian via aptitude (Omnibus installation), it doesn't find it's PostgreSQL database(s) and aborts the installation process.

Steps to reproduce

  • I have a working GitLab-EE 12.8.7 Omnibus installation running on Debian.
  • Update the package list
  • Select gitlab-ee 12.9.0 for installation/upgrade

What is the current bug behavior?

The database backup before upgrade couldn't be created.

What is the expected correct behavior?

Installation shouldn't fail on the database backup step.

Relevant logs and/or screenshots

root@gitlab:~# aptitude
Performing actions...
Changelogs werden gelesen... Fertig
(Lese Datenbank ... 234646 Dateien und Verzeichnisse sind derzeit installiert.)
Vorbereitung zum Entpacken von .../gitlab-ee_12.9.0-ee.0_amd64.deb ...
gitlab preinstall:
gitlab preinstall: This node does not appear to be running a database
gitlab preinstall: Skipping version check, if you think this is an error exit now
gitlab preinstall:
gitlab preinstall: Automatically backing up only the GitLab SQL database (excluding everything else!)
2020-03-22 19:57:38 +0100 -- Dumping database ...
Dumping PostgreSQL database gitlabhq_production ... pg_dump: [archiver (db)] connection to database "gitlabhq_production" failed: FATAL:  Peer authentication failed for user "gitlab"
[FAILED]
rake aborted!
Backup::Error: Backup failed
/opt/gitlab/embedded/service/gitlab-rails/lib/backup/database.rb:45:in `dump'
/opt/gitlab/embedded/service/gitlab-rails/lib/tasks/gitlab/backup.rake:107:in `block (4 levels) in <top (required)>'
/opt/gitlab/embedded/service/gitlab-rails/lib/tasks/gitlab/backup.rake:10:in `block (3 levels) in <top (required)>'
/opt/gitlab/embedded/bin/bundle:23:in `load'
/opt/gitlab/embedded/bin/bundle:23:in `<main>'
Tasks: TOP => gitlab:backup:db:create
(See full trace by running task with --trace)
gitlab preinstall:
gitlab preinstall: Database backup failed! If you want to skip this backup, run the following command and try again:
gitlab preinstall:
gitlab preinstall:  sudo touch /etc/gitlab/skip-auto-backup
gitlab preinstall:
dpkg: Fehler beim Bearbeiten des Archivs /var/cache/apt/archives/gitlab-ee_12.9.0-ee.0_amd64.deb (--unpack):
 »neues gitlab-ee-Skript des Paketes pre-installation«-Unterprozess gab den Fehlerwert 1 zurück
Fehler traten auf beim Bearbeiten von:
 /var/cache/apt/archives/gitlab-ee_12.9.0-ee.0_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)
Press Return to continue, 'q' followed by Return to quit.

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

root@gitlab:~# sudo gitlab-rake gitlab:env:info

System information System: Debian testing Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.5p114 Gem Version: 2.7.10 Bundler Version:1.17.3 Rake Version: 12.3.3 Redis Version: 5.0.7 Git Version: 2.24.1 Sidekiq Version:5.2.7 Go Version: unknown rake aborted! PG::ConnectionBad: FATAL: Peer authentication failed for user "gitlab" /opt/gitlab/embedded/service/gitlab-rails/lib/tasks/gitlab/info.rake:48:in block (3 levels) in <top (required)>' /opt/gitlab/embedded/bin/bundle:23:in load' /opt/gitlab/embedded/bin/bundle:23:in `' Tasks: TOP => gitlab:env:info (See full trace by running task with --trace)

Results of GitLab application Check

Expand for output related to the GitLab application check

root@gitlab:~# sudo gitlab-rake gitlab:check SANITIZE=true Checking GitLab subtasks ...

Checking GitLab Shell ...

GitLab Shell: ... GitLab Shell version >= 11.0.0 ? ... OK (11.0.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Gitaly ...

Gitaly: ... default ... OK

Checking Gitaly ... Finished

Checking Sidekiq ...

Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Incoming Email ...

Incoming Email: ... Reply by email is disabled in config/gitlab.yml

Checking Incoming Email ... Finished

Checking LDAP ...

LDAP: ... LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab App ...

Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... Exception: FATAL: Peer authentication failed for user "gitlab"

GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... Exception: FATAL: Peer authentication failed for user "gitlab"

Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.5) Git version >= 2.22.0 ? ... yes (2.24.1) Git user has default SSH configuration? ... yes Active users: ... Exception: FATAL: Peer authentication failed for user "gitlab"

Is authorized keys file accessible? ... yes Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)

Checking GitLab App ... Finished

Checking GitLab subtasks ... Finished

Possible fixes

  • No idea ...