Consider Removing the logs view from the admin interface
We currently have an admin interface that allows users to view logfiles that lives on /admin/logs
. These logs are read through subclasses of Gitlab::Logger
and the files are supposed to live in Rails.root.join('log')
.
For some logs (for example sidekiq.log
) this is not true, and we actually symlink the actual location omnibus-gitlab!182 (merged). This does not work when running sidekiq-cluster, or when sidekiq is not running on the node for another reason.
This approach does not really make sense in HA environments: since multiple nodes would be writing to those logs but they are not shared, so depending on which web-node is hit, the logs would be different. In other cases, like the Sidekiq case mentioned before, the logs would be empty, because a web-node does not run sidekiq.
So this means the views are incomplete and sometimes incorrect. I think we should consider removing this page.