Directories containing Japanese characters are not rendered
Summary
After updating GitLab from 12.4.2 to 12.8.1, directories containing Japanese characters in a project are not rendered.
Steps to reproduce
- Open a project main page
- Check "directories containing Japanese characters" in file list
Example Project
- Deploy GitLab omnibus package using docker-compose
- Tag:
gitlab/gitlab-ce:12.8.1-ce.0
What is the current bug behavior?
Directories containing Japanese characters in the repository are not rendered.
What is the expected correct behavior?
Directories containing Japanese characters in the repository are rendered.
Relevant logs and/or screenshots
Name item is not rendered and Last Commit and Last Update items are also not loaded as placeholders.
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 2.6.5p114 Gem Version: 2.7.10 Bundler Version:1.17.3 Rake Version: 12.3.3 Redis Version: 5.0.7 Git Version: 2.24.1 Sidekiq Version:5.2.7 Go Version: unknown
GitLab information Version: 12.8.1 Revision: d18b43a5f5a Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.12 URL: http://xxxxxxxxxx.com HTTP Clone URL: http://xxxxxxxxxx.com/some-group/some-project.git SSH Clone URL: git@xxxxxxxxxx.com:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 11.0.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 11.0.0 ? ... OK (11.0.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ...
--- all yes ---
Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.5) Git version >= 2.22.0 ? ... yes (2.24.1) Git user has default SSH configuration? ... yes Active users: ... 196 Is authorized keys file accessible? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes
In the case of gitlab.com, Japanese characters in query parameters of API request are URL-encoded, but in my case of Gitlab, it seems to be encoded in Unicode. As a result, returned Bad Request 400.
API Request on gitlab.com:
Request URL: https://gitlab.com/test-project/-/refs/master/logs_tree/%E3%81%82%E3%81%84%E3%81%86%E3%81%88%E3%81%8A?format=json&offset=0
API Request on my gitlab:
Request URL: https://xxxxxxxxxx.com/test-project/-/refs/master/logs_tree/%u3042%u3044%u3046%u3048%u304A?format=json&offset=0
