Take Note confidential attribute into account for search
As mentioned in #207468 (comment 295373155) we'll need to ensure that the confidential
attribute for notes is respected in the same way the confidential
attribute for issues is, which implies some changes to how the notes search and indexing takes place.
As an absolute minimum, we could exclude all confidential notes from ES-backed search.
Works needs to be done on this include:
- Indexing the new column in Elasticsearch
- Updating the spec to cover new permutations of private notes (see
ee/spec/services/search/*_service_spec.rb
) - Update
NoteClassProxy
to make the specs pass (see IssueClassProxy for example of filtering on confidential issue).
This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.