Geo - Does not retry uploads marked as successful but missing on the primary
Summary
Currently, the Geo::FileDownloadDispatchWorker
on a Geo secondary node will retry upload files marked as successful but missing on the primary indefinitely if it still has capacity, see: https://gitlab.com/gitlab-org/gitlab/blob/master/ee/app/workers/geo/file_download_dispatch_worker.rb#L64.
We should rely on the re-verification feature to resync these files as necessary. If the files suddenly appeared on the primary node, then their checksums will change, secondaries will reverify, and mark them for sync.
Related issues
https://sentry.gitlab.net/gitlab/staginggitlabcom/issues/1130708/
Edited by Gabriel Mazetto