Deprecate Settings.artifact['path'] (and Settings.lfs['path'] as well?)

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Per https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3867#note_55342372

In the config/gitlab.yml configuration file, we have these settings:

  artifact:
    path: ... # deprecated
    storage_path: ...

If path is set, it will be used in preference to storage_path but we should aim to remove it completely.

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/config/initializers/1_settings.rb#L344

We should also check whether the same is true for the lfs key. I suspect it should / does.

Settings.uploads['path'] does not exist and is not supported.

/cc @smcgivern @mbergeron