Failures in qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb | Create Restricted protected branch push and merge when only one {group|user} is allowed to merge...
Summary
https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/451302544
Stack trace
1) Create Restricted protected branch push and merge when only one group is allowed to merge and push to a protected branch behaves like only user with access pushes and merges unselected maintainer user fails to push
Failure/Error:
expect { push_new_file(branch_name, as_user: user_maintainer) }.to raise_error(
QA::Git::Repository::RepositoryCommandError,
/remote: GitLab: You are not allowed to push code to protected branches on this project\.([\s\S]+)\[remote rejected\] #{branch_name} -> #{branch_name} \(pre-receive hook declined\)/)
expected QA::Git::Repository::RepositoryCommandError with message matching /remote: GitLab: You are not allowed to push code to protected branches on this project\.([\s\S]+)\[remote rejected\] protected-branch -> protected-branch \(pre-receive hook declined\)/, got #<QA::Git::Repository::RepositoryCommandError: The command HOME="/tmp/qa-netrc-credentials/22" git pu...st-2020-02-26-18-24-50-5219ece21f6103dd/group-with-access-to-protected-branch-f121dbb4211f53c3.git'> with backtrace:
# ./qa/git/repository.rb:221:in `run'
# ./qa/git/repository.rb:116:in `push_changes'
# ./qa/resource/repository/push.rb:98:in `block in fabricate!'
# ./qa/scenario/actable.rb:16:in `perform'
# ./qa/git/repository.rb:33:in `block (2 levels) in perform'
# ./qa/git/repository.rb:33:in `chdir'
# ./qa/git/repository.rb:33:in `block in perform'
# ./qa/git/repository.rb:32:in `perform'
# ./qa/resource/repository/push.rb:50:in `fabricate!'
# ./qa/resource/base.rb:30:in `block (2 levels) in fabricate_via_browser_ui!'
# ./qa/resource/base.rb:135:in `log_fabrication'
# ./qa/resource/base.rb:30:in `block in fabricate_via_browser_ui!'
# ./qa/resource/base.rb:118:in `do_fabricate!'
# ./qa/resource/base.rb:29:in `fabricate_via_browser_ui!'
# ./qa/resource/base.rb:21:in `rescue in fabricate!'
# ./qa/resource/base.rb:18:in `fabricate!'
# ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:111:in `push_new_file'
# ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:13:in `block (5 levels) in <module:QA>'
# ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:13:in `block (4 levels) in <module:QA>'
...
Shared Example Group: "only user with access pushes and merges" called from ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:98
# ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:13:in `block (4 levels) in <module:QA>'
2) Create Restricted protected branch push and merge when only one user is allowed to merge and push to a protected branch behaves like only user with access pushes and merges unselected maintainer user fails to push
Failure/Error:
expect { push_new_file(branch_name, as_user: user_maintainer) }.to raise_error(
QA::Git::Repository::RepositoryCommandError,
/remote: GitLab: You are not allowed to push code to protected branches on this project\.([\s\S]+)\[remote rejected\] #{branch_name} -> #{branch_name} \(pre-receive hook declined\)/)
expected QA::Git::Repository::RepositoryCommandError with message matching /remote: GitLab: You are not allowed to push code to protected branches on this project\.([\s\S]+)\[remote rejected\] protected-branch -> protected-branch \(pre-receive hook declined\)/, got #<QA::Git::Repository::RepositoryCommandError: The command HOME="/tmp/qa-netrc-credentials/22" git pu...est-2020-02-26-18-24-50-5219ece21f6103dd/user-with-access-to-protected-branch-1a58d7c0d474eee9.git'> with backtrace:
# ./qa/git/repository.rb:221:in `run'
# ./qa/git/repository.rb:116:in `push_changes'
# ./qa/resource/repository/push.rb:98:in `block in fabricate!'
# ./qa/scenario/actable.rb:16:in `perform'
# ./qa/git/repository.rb:33:in `block (2 levels) in perform'
# ./qa/git/repository.rb:33:in `chdir'
# ./qa/git/repository.rb:33:in `block in perform'
# ./qa/git/repository.rb:32:in `perform'
# ./qa/resource/repository/push.rb:50:in `fabricate!'
# ./qa/resource/base.rb:30:in `block (2 levels) in fabricate_via_browser_ui!'
# ./qa/resource/base.rb:135:in `log_fabrication'
# ./qa/resource/base.rb:30:in `block in fabricate_via_browser_ui!'
# ./qa/resource/base.rb:118:in `do_fabricate!'
# ./qa/resource/base.rb:29:in `fabricate_via_browser_ui!'
# ./qa/resource/base.rb:21:in `rescue in fabricate!'
# ./qa/resource/base.rb:18:in `fabricate!'
# ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:111:in `push_new_file'
# ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:13:in `block (5 levels) in <module:QA>'
# ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:13:in `block (4 levels) in <module:QA>'
...
Shared Example Group: "only user with access pushes and merges" called from ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:62
# ./qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb:13:in `block (4 levels) in <module:QA>'
Screenshot / HTML page
Possible fixes
Revert and fix !25936 (merged)?
Still investigating...
Edited by Mark Lapierre