Skip to content

allow delete on protected tags if user has authority

Summary

After making a tag protected you are not then able to delete the tag even when you have been assigned the authority.

Workaround is to unprotect tag, delete tag, the protect tags

Steps to reproduce

Add a protected wildcard tag to a repo via settings > protected tags Add a protected tag to the repo via repo > tags > new tag Unable to delete protected tag via repo > tags delete is not enabled

What is the current bug behavior?

Unable to delete tags even though I'm logged as a user with authority.

What is the expected correct behavior?

Delete icon to be enabled

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:         Ubuntu 16.04
Proxy:          no
Current User:   git
Using RVM:      no
Ruby Version:   2.3.5p376
Gem Version:    2.6.13
Bundler Version:1.13.7
Rake Version:   12.3.0
Redis Version:  3.2.11
Git Version:    2.14.3
Sidekiq Version:5.0.4
Go Version:     unknown

GitLab information
Version:        10.3.3-ee
Revision:       3f64be9
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
DB Version:     9.6.5
URL:            https://astrachan-latest.asgks.net
HTTP Clone URL: https://astrachan-latest.asgks.net/some-group/some-project.git
SSH Clone URL:  git@astrachan-latest.asgks.net:some-group/some-project.git
Elasticsearch:  no
Geo:            no
Using LDAP:     no
Using Omniauth: yes
Omniauth Providers: saml


GitLab Shell
Version:        5.10.2
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
unable_to_delete_protected_tag

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)