Follow-up from "WIP: Cluster Embed Metric Dashboard Endpoint"
The following discussion from !25739 (merged) should be addressed:
-
@allison.browne started a discussion: We have to call
[:dashboard].deep_stringify_keys
to make this matchbase_dashboard
. Sobase_dashboard
refers to a raw_dashboard from.find_raw
rather than the formatted one from.find
.This seems non-ideal because we are converting like this
raw -> formatted -> raw
.Perhaps we should have
base_dashboard
always return a formatted dash across all classes and subclasses ofDynamicEmbedService
. I'll create an issue and let me know your thoughts @syasonik.
Edited by Allison Browne