Follow up refactor for: E2e test add custom metric
Summary
This is a follow up issue for the refactoring of the work done in the first iteration of E2e test add custom metric
Improvements
-
The test needs to perform CRUD operations, so Update and Delete assertions need to be included -
The alerting_spec.rb
andcluster_health_spec.rb
should be refactored/merged in a way that they share the same costly setup (the goal is not to add up a lot of time to the test run)
Risks
Involved components
- qa/qa/specs/features/ee/browser_ui/8_monitor/apm/metrics_spec.rb
- qa/qa/specs/features/ee/browser_ui/8_monitor/health/alerting_spec.rb
- qa/qa/specs/features/ee/browser_ui/8_monitor/health/cluster_health_spec.rb
- qa/qa/ee/page/project/operations/metrics/show.rb
Optional: Intended side effects
Optional: Missing test coverage
Edited by Sofia Vistas