Implement Danger Telemetry Review

Each merge request with changes to telemetry to be reviewed by the telemetry team.

Details

  1. We need to add a new danger similar to database team: https://gitlab.com/gitlab-org/gitlab/-/blob/master/danger/database/Dangerfile like danger/telemetry/Dangerfile
  2. Danger review bot to ping the telemetry team and the data team.

Changes

  1. Any change which touches
  2. Any change which has telemetry tracking

1. Files which are related to telemetry

See helper.changes_by_category[:telemetry] for one of the *usage_data* files

$ find . -name *usage_data*
./lib/gitlab/cycle_analytics/usage_data.rb
./lib/gitlab/usage_data_counters
./lib/gitlab/usage_data.rb
./lib/gitlab/grafana_embed_usage_data.rb
./ee/lib/gitlab/usage_data_counters
./ee/lib/ee/gitlab/usage_data.rb
./ee/spec/lib/gitlab/usage_data_spec.rb
./ee/spec/lib/gitlab/usage_data_counters
./ee/spec/lib/ee/gitlab/usage_data_spec.rb
./spec/lib/gitlab/usage_data_spec.rb
./spec/lib/gitlab/grafana_embed_usage_data_spec.rb
./spec/lib/gitlab/cycle_analytics/usage_data_spec.rb
./spec/lib/gitlab/usage_data_counters
./spec/support/shared_examples/lib/gitlab/usage_data_counters

2. Any change which has snowplow events

or .track_events are called in 'tracking.rb' and 'tracking.js'

Edited by Jerome Z Ng