Follow-up from "Adds sorting to group packages api"
The following discussion from !24432 (merged) should be addressed:
-
@rspeicher started a discussion: (+1 comment) These variables create a mystery guest problem in that they're not actually used anywhere directly in the spec, but rather are implicit setup in the shared examples.
But that problem pre-dated this merge request, so fair enough. However, I think we're now compounding the problem by adding implicit meaning to their attributes -- the
version
andname
are important, but we don't know why until we read thewith sorting
specs, and even that's difficult to parse out.I think I'd almost rather leave these two lines as they were, and then overwrite them within the context on line 24. At least that keeps the meaning closer to where it's important. WDYT?