Adding New Changes to Merge Request Enables Merge Button For Non Maintainer
Summary
When adding new changes to an existing merge request, the "Merge" button appears to be enabled for a non-maintainer before refreshing the page.
Note: Have not yet attempted to execute merge button to see what happens.
Steps to reproduce
As a non-maintainer:
- Create branch
- Push code changes to branch
- Create merge request for branch
- Make additional changes and push to branch
- WITHOUT REFRESHING PAGE -> Merge button becomes enabled along with message "New changes were added"
Additional Steps:
- Refresh page -> Merge button becomes disabled again
Example Project
Example project where this issue is noticed is not available to public. Can create example if necessary to reproduce but the but appears to be local and not in the server.
What is the current bug behavior?
Merge button becomes enabled for a non-maintainer when new changes are added
What is the expected correct behavior?
Merge button is never enabled for a non-maintainer
Relevant logs and/or screenshots
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
This is on an older version: GitLab Community Edition 12.7.5
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production
)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)