Custom workflows - Group configuration
- Many large companies need custom workflows as part of their issue management, as stated here: https://gitlab.com/gitlab-org/gitlab-ee/issues/1743.
- An example is that a team needs to ensure every single issue goes through exactly these stages: "To Do" > "In Dev" > "In QA" > "Code review" > "UAT" > "Ready for release" > "Post-production check".
- Per group, configure the custom workflow states for issues.
- Define allowable workflow states.
- State is different from workflow states.
- GitLab issues have only two states.
- When an issue is
Open, it can be in one of several customized workflow states.
- When an issue is
Closed, it doesn’t belong to any workflow state by definition. (I.e. its workflow state is null.)
- By default there are two customized workflow states called
Development. You can change the names of these workflow states. These two workflow states come as part of any new group created.
- When an issue is created, it starts in the first workflow state (part of the Open state) by default.
- You can create any number of workflow states per group, but you can only delete down to two workflow. I.e. minimum two workflow states per group.
- GitLab won't check if you use the same name for multiple workflow states.
- When you delete a workflow state, for all issues that were in that workflow state, they just go "backward" a stage. If the first workflow state was deleted, then all issues in that workflow state just go "forward" a workflow state.
- An issue takes the workflow states from its immediate parent group.
In the group configuration, we could have something like this, to allow an admin to configure the workflow states.
- Issue lists and existing issue boards and burndowns work the same as now since there are still the same two defined states.
- There is a new group board type. This special board type has all lists predefined which are the custom stages. You can config the board as normal. But cannot add/remove lists. &424
Value stream management
- The workflow design here needs to work with VSM. See &505. So we need to be careful in designing the workflow states so it is straightforward to calculate times in a given workflow state and it is well-defined.
- In particular, there is an outstanding problem to identify cycle time versus lead time. Cycle time is the time required for an issue to be worked on a shipped. Lead time also includes the additional time before the issue is even worked on, and is first logged by a customer. So while cycle time is focused on operational excellence, lead time is even more important, because it measures responsiveness of an organization to customer feedback.
- I think we should focus on cycle time first, because it is easier to define within GitLab given or existing abstractions. Lead time is harder because for example in GitLab, issues are often open/closed/re-opened/moved and often an issue stays around for a long time before we consider implementing it, but that doesn't reflect badly that we are ignoring customers.
Groups vs projects and workflow states
- Within an issue page, you will be able to see what workflow state it is in (only if it is
Open). And you can transition to another workflow state. Or simply close the issue. In particular, within an issue, you should only see one workflow state. This is the problem that Jira ran into which became very complicated. Even though an issue belongs to one project, which belongs to a group and indirectly a family tree of groups, it should only ever have a single workflow state. So we probably should allow workflow state schemes to be defined at multiple projects and groups, an issue should only ever have a single workflow state.
- I think we should start defining workflow states in a single group, and not even bring this functionality to projects at all, to avoid confusion. Teams that need this level of precision and management are typically already using groups. For teams using projects to do workflow management, we can ask them to use labels, the existing method.
- So if you have a single group, and a set of workflow states defined for that group, all issues (in projects) in that group share the same workflow states, and everything is well-defined. You can also have group issue boards that use that workflow board. See &424.
- What happens now with subgroups? There is a need to define workflow states at higher-level ancestor groups since organizations want consistency at a higher management level, and want all teams lower down that tree to use the same workflow states. This should be tackled in future iterations, but we should try to have the best design upfront before we iterate there.
- I think we should have a simple overriding mechanism: Given the following group hierarchy from oldest to youngest:
Group A > Group B > Group C > Project P > Issue x. Again, issue
xalways has one well-defined workflow state. (Or at most one. It can have done if the workflow states are not defined.) Groups
A, B, Ccan all have their own workflow states defined. But
A. For example, if only
Ahas workflow states defined (and
Cdon't), then issue
A's workflow states. If
Bhas its own workflow states, then issue
B's. And if
Chas its own workflow states, then issue
- There are at least two salient consequences of this design:
- Given a project
P, all issues in
Pwill have the same workflow states.
- Given a group
G, different issues in
Gmay have different workflow states. So that means if you create a workflow issue board in
G(i.e. &424), not all issues in
Gmay appear in that workflow issue board. I think this design is okay. But we should be aware of this and make a conscious designs/decisions along the way.
- Given a project
This issue and https://gitlab.com/gitlab-org/gitlab-ee/issues/8181 should be implemented and released together as a first iteration. Since they are both big issues, I (Victor) think we should do this one, release it hidden behind feature flag so that the feature is off by default. And then when https://gitlab.com/gitlab-org/gitlab-ee/issues/8181 is ready, then have feature flag be removed altogether.