When disabling SSH access (i.e. setting access to "Only HTTP(S)"), you still have to set a minimum of 1 ssh key type to allowed
Summary
When disabling SSH access (i.e. setting access to "Only SSH"), you still have to set a minimum of 1 ssh key type to allowed.
Steps to reproduce
- Log in to a Gitlab setup as admin
- Access the System Settings under the Admin Area
- Set "Enabled Git access protocols" to "Only HTTP(S)"
- Now try to set all SSH Keys settings to "Are forbidden", because you just set it to only allow HTTP(S)
- Save config. It will tell you:
The form contains the following error: Allowed key types can't be blank
- Then set at least one of the "SSH keys" fields to anything other than "Are forbidden", and save the config again. It will work.
Example Project
It is not a project thing, it's a system administration thing.
What is the current bug behavior?
That the configuration is inconsistent, because it feels you forbid SSH, but still allow a certain SSH key type.
What is the expected correct behavior?
That the check on the "Allowed key types can't be blank" be skipped if the "Enabled Git access protocols" is set to "Only HTTP(S)", so that the configuration is consistent.