Design link unfurling: Display thumbnails in issue descriptions and comments using specific url vars + markdown
Problem to solve
Intended users
Further details
Proposal
Paste a link and modifying the link to show the design thumbnail
Builds on top of Support Design Links in markdown: #12905 (closed)
1) Normal link as implemented in #12905 (closed)
https://gitlab.com/gitlab-org/gitlab/issues/12905/designs/Screenshot%202019-08-06%2020.32.02.png
becomes with markdown #12905 (design)
2) Add on optional var ?thumbnail=small
Options for thumbnails are:
-
true(thumbnail sized) -
small(thumbnail sized) -
medium(issue width) -
large(desktop width) original
becomes
NEED DESIGN
3) Add on optional var ?v=2 locks it to that version, otherwise it shows the latest version.
NEED DESIGN
4) If design is deleted, show the following in its place:
NEED DESIGN
Permissions and Security
- Consider viewing of confidential issues and their designs
Documentation
TBD
Proposal from @jareko
- Sketch cloud specs: https://sketch.cloud/s/EJnk2/v/dlzEkm/
- See designs tab for final designs
Availability & Testing
What does success look like, and how can we measure that?
Links / references
Edited by Jarek Ostrowski