Follow-up from "WIP: Update testAction to reject return values"
The following discussion from !24636 (closed) should be addressed:
-
@pslaughter started a discussion: (+1 comment) todo: @jboyson I'm looking to add a test assertion that will prevent us from returning any values from Vuex actions. This will help enforce good component design that is reactive to state changes and not tightly coupled to the management of state.
In a separate MR, could you please refactor this
fetchDiffFiles
andfetchDiffFilesMeta
actions to update some state instead of returning a value? What do you think?
feel free to disagree with this approach.
😄 I'm putting this MR together mostly to see the scope of violations we have to this proposed "rule"