Invitees cannot sign up if their email domain is not whitelisted, but they did get an invite to that email.

Summary

If you have email domain whitelisting setup for a GL instance, but choose to send an invite to a non-whitelisted domain email address, they get the invite but cannot sign up using that email. I think if they have been explicitly invited they should be allowed to register with the invited email address. Possibly show a warning before sending the invite in the UI.

Steps to reproduce

  • Set GL.
  • Add whitelisting for signups.
  • Invite someone using a non-whitelisted domain email.
  • They get the email ok.
  • When trying to sign up they get:

1 error prohibited this user from being saved:

Email domain is not authorized for sign-up

What is the current bug behavior?

Prevents the user singing up

What is the expected correct behavior?

Allows sign up. Maybe show a warning when inviting.

Relevant logs and/or screenshots

GL

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:		Ubuntu 16.04
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.3.5p376
Gem Version:	2.6.13
Bundler Version:1.13.7
Rake Version:	12.1.0
Redis Version:	3.2.5
Git Version:	2.13.6
Sidekiq Version:5.0.4
Go Version:	unknown

GitLab information
Version:	10.1.4-ee
Revision:	a512054
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
DB Version:	9.6.5
URL:		https://REDACTED.net
HTTP Clone URL:	https://REDACTED.net/some-group/some-project.git
SSH Clone URL:	git@REDACTED.net:some-group/some-project.git
Elasticsearch:	yes
Geo:		no
Using LDAP:	no
Using Omniauth:	no


GitLab Shell
Version:	5.9.3
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab Shell ...

GitLab Shell version >= 5.9.3 ? ... OK (5.9.3)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
2/1 ... ok
2/2 ... ok
2/3 ... ok
2/5 ... ok
2/6 ... ok
18/7 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Sidekiq ...


Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Reply by email is disabled in config/gitlab.yml
Checking LDAP ...


LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
2/1 ... yes
2/2 ... yes
2/3 ... yes
2/5 ... yes
2/6 ... yes
18/7 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.3 ? ... yes (2.3.5)
Git version >= 2.7.3 ? ... yes (2.13.6)
Git user has default SSH configuration? ... no
Try fixing it:
mkdir ~/gitlab-check-backup-1511171341
sudo mv /var/opt/gitlab/.ssh/id_rsa.pub ~/gitlab-check-backup-1511171341
sudo mv /var/opt/gitlab/.ssh/id_rsa ~/gitlab-check-backup-1511171341
For more information see:
doc/ssh/README.md in section "SSH on the GitLab server"
Please fix the error above and rerun the checks.
Active users: ... 13
Elasticsearch version 5.1 - 5.5? ... no (5.6.3)
For more information see:
doc/integration/elasticsearch.md


Checking GitLab ... Finished