JS Tests should not use 'should'

Almost all our js tests say it('should do something') instead of it('does something')

We have this in test docs (for rspec tests) but I cannot find it.

Also mentioned here though: http://www.betterspecs.org/#should

Edited by 🤖 GitLab Bot 🤖