Skip to content

Make the non-diff commit comments contextual to the merge request

Description

This is a follow-up issue for gitlab-ce#31847 after gitlab-ce!12148 is merged.

In the commit page, when in the context of a merge request, the non-diff comments are still contextual on the Commit which implies that:

  • Shown in the merge request discussion tab as long as the commit is part of the MR
  • Shown in the merge request discussion tab as a single non-resolvable discussion

Proposal

Use an analogous logic to gitlab-ce!12148 for the commits comments.

Links / references

Documentation blurb

Overview

Why should someone use this feature? This is to support a better per-commit review workflow.

What is the underlying (business) problem? Non-diff commits comments are contextual to the Commit and not to the MergeRequest.

How do you use this feature?

Open a merge request
  Commits tab -> click a commit
    Commit page (with merge_request context) -> click View details
      Comment on the commit (not on a diff) /
      Start a discussion on the commit (not on a diff)

Use cases

Who is this for? Provide one or more use cases. See gitlab-ce#39380, gitlab-ce#35287

This should be done before gitlab-ce#40044.

Feature checklist

Make sure these are completed before closing the issue, with a link to the relevant commit.