Skip to content

Add correct anchor link to new policy tab

Problem to solve

#14061 (closed) migrated the license compliance section from project > settings > ci/cd > license compliance to project > security > license compliance > polices. 1) The former is no longer needed (proje...ci/cd > license compliance) to be deprecated and 2) anchors in the MR (to the policy section) link to the former LC section.

Additionally, the new policies section may be seen by both maintainers and developers. The current link in MR is only shown to the maintainer.

current

Also in "Licenses tab" in Pipeline view

Screen_Shot_2020-03-26_at_11.37.51_AM

Additional Notes (From Fernando)

  • We should AUDIT other places we link from. These 2 areas are the only ones I'm aware of. (-Fernando)

We need to add Vue Routing to handle navigating to the license compliance page + default selecting the "Policies" tab. (Policies tab represents the License Compliance from Settings -> CI/CD area)

Intended users

Proposal

After the completion of #14061 (closed):

  1. Revise anchors in MR UI to link to new policies tab (flows below)
  2. Remove the deprecated LC section project > settings > ci/cd > license compliance.

proposal

Permissions and Security

  • Developer view has an anchor that leads to View policies policies
  • Maintainer view has an anchor that leads to Manage Licensesview/add/edit/delete policies
  • Public projects policy section is not visible to non-project participants (#33659 (closed))
  • not logged in - no tab and no count

Implementation

Documentation

Testing

  • Add tests to ensure the hash-linking to individual tabs within license_compliance/components/app.vue to support linking to a tab (mapping window.location.hash to data.tabIndex) works as expected
Edited by -