Hide buttons for the group of deploys for the same revision
Summary
Rollback
button is shown for the same revision as the Re-deploy
button, semantically, it's in fact a Re-deploy
instead of a rollback
, this could lead to misinformation and mistakenly be rollbacking the same revision
Steps to reproduce
Re-Deploy two or more times in an environment, the Rollback button is shown for the same revision
What is the expected correct behavior?
hide action buttons "Rollback/Re-Deploy" for the same version deployed many times
Results of GitLab environment info
System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.3.5p376 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.0.0 Redis Version: 3.2.5 Git Version: 2.13.5 Sidekiq Version:5.0.4 Go Version: unknownGitLab information Version: 10.0.3 Revision: 8895150 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: http://OUR-HOSTNAME HTTP Clone URL: http://OUR-HOSTNAME/some-group/some-project.git SSH Clone URL: git@OUR-HOSTNAME:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 5.9.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
- storage1: /mnt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Possible fixes
Hide buttons for the group of deploys for the same revision