Commit References Start MR Discussions

Summary

When a commit message contains a reference to a MR commit, the system note for the reference is rendered as a discussion on the MR.

Steps to reproduce

  1. Create a MR with multiple commits
  2. Merge the MR
  3. Cherry pick the MR to another branch

Example Project

https://gitlab.com/deckar01/gitlab-ce-permissions-test/merge_requests/3

What is the current bug behavior?

A discussion is started on the merged MR for each commit in the merged branch.

What is the expected correct behavior?

Commit references should not be discussions, and they might not be needed in the MR discussion at all.

Relevant logs and/or screenshots

Screen_Shot_2017-10-18_at_1.00.38_PM

Output of checks

This bug happens on GitLab.com

Possible fixes

  • Don't render commit reference notes in MR discussions
  • Render commit reference notes as MR system notes instead of discussions
Edited by 🤖 GitLab Bot 🤖