Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,769
    • Issues 44,769
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,331
    • Merge requests 1,331
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #198458
You need to sign in or sign up before continuing.
Closed
Open
Issue created Jan 23, 2020 by James Ramsay (ex-GitLab)@jramsay-gitlab🔴Contributor

Make merge-ref diffs the default comparison mode

Problem to solve

Merge request diffs are currently calculated by git diff target...source which compares HEAD of target with the merge base of target and source. This works well until changes from the target branch are merged in to the source branch, creating a complete mess of the diff.

Further details

In previous iterations we've added a new diff mode, and implemented commenting support. This issue will make it the default comparison mode.

Proposal

This should definitely be feature flagged, so that it can be enabled for individual projects and groups for testing.

When viewing a merge request diff, when comparing between Latest version and master this should default to comparing using the merge-ref. The merge-base method should not be available any more.

Screen_Shot_2019-02-26_at_2.21.48_PM

Links / references

Edited Apr 15, 2020 by Daniel Gruesso
Assignee
Assign to
Time tracking