Reviews: batch comments on merge requests
Problem
I want prevent notification overload by grouping comments, stage comments and submit them (email people) in the end.
Possible solutions:
- Have 'Draft comment' and 'Submit comment' buttons
- Have checkbox or review mode 'bundle comments'
- Something else
Phabricator solved this already.
Thanks to Eric Vander Weele
Scope
- The scope of this issue is the batch commenting functionality.
- Changes to emails are not in scope.
- For other improvements see &23 (closed)
Design
We're going to call the batch commenting feature: “review”. A review is a group of comments that are published together. You can start a review, add a comment to a review, discard a review, and finish/submit a review.
The review feature is only available in merge requests, when creating a discussion from a code line, or replying to a discussion (from a code line or from the “Discussion” tab) — it is not available when adding a comment/discussion in the “Discussion” tab.
One of the main changes is replacing the “Comment” and “Comment and resolve discussion” buttons with: a new “Start a review” button; a “Add comment now” button (same function as the current “Comment” button); and a “Resolve discussion” checkbox.
Here's the flow with notes:
This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.