New tag via UI `Create from` not resetting as expected.

Summary

Create a tag using the UI from a specific commit, but change your mind to use (master) branch, tag is created against the specified commit.

Steps to reproduce

  • Navigate to tags
  • Click New tag
  • In the Create from field enter a valid commit hash into Filter by Git revision so it properly populates the Create from field
  • Change your mind and click on hash in Create from field
  • Click the cross on the current value to remove it and allow selecting branches again
  • Select branch e.g. master

Create from field now has no contents and if you click Create tag the tag will be created against the commit hash you originally entered.

What is the current bug behavior?

  • Create from field becomes empty.
  • Hidden input html form tag still has the value of the commit hash you entered.
  • Forms submission via Create tag uses this to create the tag against the incorrect commit.

What is the expected correct behavior?

When reselecting a branch (e.g. master) it correctly fills the Create from field and the hidden input field.

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:		Debian 8.9
Current User:	git
Using RVM:	no
Ruby Version:	2.3.5p376
Gem Version:	2.6.13
Bundler Version:1.13.7
Rake Version:	12.0.0
Redis Version:	3.2.5
Git Version:	2.13.5
Sidekiq Version:5.0.4
Go Version:	unknown


GitLab information
Version:	10.0.3
Revision:	8895150
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
URL:		https://gitlab.riskpoint.co.uk
HTTP Clone URL:	https://gitlab.riskpoint.co.uk/some-group/some-project.git
SSH Clone URL:	git@gitlab.riskpoint.co.uk:some-group/some-project.git
Using LDAP:	no
Using Omniauth:	no


GitLab Shell
Version:	5.9.0
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab Shell ...


GitLab Shell version >= 5.9.0 ? ... OK (5.9.0)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
2/1 ... ok
6/2 ... ok
5/4 ... ok
4/8 ... ok
4/9 ... ok
4/10 ... ok
4/11 ... ok
4/12 ... ok
4/13 ... ok
4/14 ... ok
4/15 ... ok
8/17 ... ok
10/18 ... ok
5/19 ... ok
7/20 ... ok
8/21 ... ok
9/22 ... ok
12/25 ... ok
9/26 ... ok
9/30 ... ok
4/31 ... ok
4/32 ... ok
4/33 ... ok
4/34 ... ok
9/35 ... ok
4/37 ... ok
4/38 ... ok
9/40 ... ok
4/41 ... ok
4/42 ... ok
4/43 ... ok
9/44 ... ok
2/45 ... repository is empty
13/46 ... ok
2/47 ... ok
9/48 ... ok
9/49 ... ok
8/50 ... ok
9/51 ... ok
15/52 ... ok
17/53 ... ok
4/54 ... ok
4/55 ... ok
4/56 ... ok
2/57 ... ok
4/58 ... ok
18/59 ... ok
19/60 ... ok
20/61 ... ok
21/62 ... ok
4/63 ... ok
6/64 ... ok
22/65 ... ok
23/66 ... ok
4/67 ... ok
24/68 ... ok
25/69 ... ok
26/70 ... ok
27/71 ... ok
28/72 ... ok
29/73 ... ok
30/74 ... ok
4/75 ... ok
22/76 ... ok
31/77 ... ok
32/78 ... ok
33/79 ... ok
34/80 ... ok
25/81 ... ok
35/82 ... ok
29/83 ... ok
36/84 ... ok
19/85 ... ok
37/86 ... ok
38/87 ... ok
4/88 ... ok
40/89 ... ok
40/90 ... ok
8/92 ... ok
9/93 ... ok
39/94 ... ok
39/95 ... ok
13/96 ... ok
2/97 ... ok
36/98 ... ok
41/99 ... ok
7/100 ... ok
42/101 ... ok
43/102 ... ok
44/103 ... ok
45/104 ... ok
46/105 ... ok
46/107 ... ok
46/108 ... ok
47/109 ... ok
8/110 ... ok
6/111 ... ok
6/112 ... ok
48/113 ... ok
49/115 ... ok
50/116 ... ok
51/117 ... ok
52/118 ... ok
53/119 ... ok
4/120 ... ok
54/121 ... ok
55/122 ... ok
56/123 ... ok
57/124 ... ok
4/125 ... ok
58/126 ... ok
59/127 ... ok
60/128 ... ok
61/129 ... ok
62/130 ... ok
63/131 ... ok
6/133 ... ok
62/134 ... ok
62/135 ... ok
64/136 ... ok
65/137 ... ok
62/138 ... ok
66/139 ... ok
5/140 ... ok
6/141 ... ok
4/142 ... ok
69/143 ... ok
9/144 ... ok
63/145 ... ok
70/146 ... ok
71/147 ... ok
72/148 ... ok
73/149 ... ok
74/150 ... ok
57/151 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Sidekiq ...


Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Reply by email is disabled in config/gitlab.yml
Checking LDAP ...


LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
2/1 ... yes
6/2 ... yes
5/4 ... yes
4/8 ... yes
4/9 ... yes
4/10 ... yes
4/11 ... yes
4/12 ... yes
4/13 ... yes
4/14 ... yes
4/15 ... yes
8/17 ... yes
10/18 ... yes
5/19 ... yes
7/20 ... yes
8/21 ... yes
9/22 ... yes
12/25 ... yes
9/26 ... yes
9/30 ... yes
4/31 ... yes
4/32 ... yes
4/33 ... yes
4/34 ... yes
9/35 ... yes
4/37 ... yes
4/38 ... yes
9/40 ... yes
4/41 ... yes
4/42 ... yes
4/43 ... yes
9/44 ... yes
2/45 ... yes
13/46 ... yes
2/47 ... yes
9/48 ... yes
9/49 ... yes
8/50 ... yes
9/51 ... yes
15/52 ... yes
17/53 ... yes
4/54 ... yes
4/55 ... yes
4/56 ... yes
2/57 ... yes
4/58 ... yes
18/59 ... yes
19/60 ... yes
20/61 ... yes
21/62 ... yes
4/63 ... yes
6/64 ... yes
22/65 ... yes
23/66 ... yes
4/67 ... yes
24/68 ... yes
25/69 ... yes
26/70 ... yes
27/71 ... yes
28/72 ... yes
29/73 ... yes
30/74 ... yes
4/75 ... yes
22/76 ... yes
31/77 ... yes
32/78 ... yes
33/79 ... yes
34/80 ... yes
25/81 ... yes
35/82 ... yes
29/83 ... yes
36/84 ... yes
19/85 ... yes
37/86 ... yes
38/87 ... yes
4/88 ... yes
40/89 ... yes
40/90 ... yes
8/92 ... yes
9/93 ... yes
39/94 ... yes
39/95 ... yes
13/96 ... yes
2/97 ... yes
36/98 ... yes
41/99 ... yes
7/100 ... yes
42/101 ... yes
43/102 ... yes
44/103 ... yes
45/104 ... yes
46/105 ... yes
46/107 ... yes
46/108 ... yes
47/109 ... yes
8/110 ... yes
6/111 ... yes
6/112 ... yes
48/113 ... yes
49/115 ... yes
50/116 ... yes
51/117 ... yes
52/118 ... yes
53/119 ... yes
4/120 ... yes
54/121 ... yes
55/122 ... yes
56/123 ... yes
57/124 ... yes
4/125 ... yes
58/126 ... yes
59/127 ... yes
60/128 ... yes
61/129 ... yes
62/130 ... yes
63/131 ... yes
6/133 ... yes
62/134 ... yes
62/135 ... yes
64/136 ... yes
65/137 ... yes
62/138 ... yes
66/139 ... yes
5/140 ... yes
6/141 ... yes
4/142 ... yes
69/143 ... yes
9/144 ... yes
63/145 ... yes
70/146 ... yes
71/147 ... yes
72/148 ... yes
73/149 ... yes
74/150 ... yes
57/151 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.3 ? ... yes (2.3.5)
Git version >= 2.7.3 ? ... yes (2.13.5)
Git user has default SSH configuration? ... no
Try fixing it:
mkdir ~/gitlab-check-backup-1507306731
sudo mv /var/opt/gitlab/.ssh/authorized_keys.lock ~/gitlab-check-backup-1507306731
For more information see:
doc/ssh/README.md in section "SSH on the GitLab server"
Please fix the error above and rerun the checks.
Active users: ... 7


Checking GitLab ... Finished