Group path validation does not handle subgroup paths properly
Summary
After creating a subgroup (e.g. with full path "test/bar") it's not possible to create a group with the same path as the previously created subgroup (e.g. "bar) any more.
Steps to reproduce
- Create new group with path "foo"
- Create subgroup with path "foo/bar"
- Create new group with path "bar" -> validation error
Group path is already taken. Suggestions: bar1
Example Project
What is the current bug behavior?
The Javascript "Suggests" API wrongly detects that the group path "bar" already exists and replaces it by "bar1". This check does not recognize that the existing group "bar" is the subgroup "foo/bar".
What is the expected correct behavior?
No validation error and no automatic suggestion "bar1"
Relevant logs and/or screenshots
Tests with Rails console of local GitLab CE 12.6.4 via Docker:
irb(main):030:0> Group.find_by_full_path('bar')
=> nil
irb(main):031:0> Group.find_by_path('bar')
=> #<Group id:80 @foo/bar>
irb(main):032:0> Namespace.find_by_path_or_name('bar')
=> #<Group id:80 @foo/bar>
irb(main):033:0> Namespace.find_by_full_path('bar')
=> nil
irb(main):034:0> Namespace.find_by_full_path('foo/bar')
=> #<Group id:80 @foo/bar>
Output of checks
This bug happens on GitLab.com
Validation error for new group:
Corresponding subgroup:
Results of GitLab environment info
Expand for output related to GitLab environment info
root@96a5cc17c73f:/# gitlab-rake gitlab:env:infoSystem information System: Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.3 Redis Version: 3.2.12 Git Version: 2.24.1 Sidekiq Version:5.2.7 Go Version: unknown
GitLab information Version: 12.6.4 Revision: 70900054dfe Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.9 URL: http://torstens-macbook-pro.local:8083 HTTP Clone URL: http://torstens-macbook-pro.local:8083/some-group/some-project.git SSH Clone URL: git@torstens-macbook-pro.local:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: saml
GitLab Shell Version: 10.3.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
root@96a5cc17c73f:/# gitlab-rake gitlab:check SANITIZE=true Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 10.3.0 ? ... OK (10.3.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 42/1 ... yes 42/2 ... yes 42/3 ... yes 42/4 ... yes 1/10 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.22.0 ? ... yes (2.24.1) Git user has default SSH configuration? ... yes Active users: ... 3 Is authorized keys file accessible? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes
Javascript "Suggests" API uses Namespace.find_by_path_or_name(namespace_path)
to check if the group path already exists. This check does not recognize subgroup paths.