Project Importers do not show any import errors if there are any

Currently when importing a project to GitLab using any of the importers (GitHub/Gitea/etc) if the error occurs it gets rescued and saved to errors array as a way to do graceful failure, instead of failing hard. Then project.import_state.last_error gets updated with that value.

For example, gitea importer: https://gitlab.com/gitlab-org/gitlab/blob/master/lib/gitlab/legacy_github_import/importer.rb#L133-134

However, while testing this behaviour I noticed 2 issues:

1. These errors are not shown in any way to the user. Importing page just indicates that the import is complete and there is no way for a user to know that something was not imported.
2. import_state.last_error gets update to nil when import is complete, so any of the errors that might have occurred during the import get wiped out. This is due to the change that has been added 2 years ago !2628 (diffs) (I am sure there has been a good reason for that). But this removes any traces of records that failed to be imported and it looks as if there were no errors during import.

If I remove last_error: nil bit and redo import there are no indications to the user of any failures except a record in the database.

The project import is indeed completed but some of the things are missing. It could be that certain repo features (like issues, pull requests) are disabled, but also because something went wrong during the record creation.

So I am wondering if:

1. We should display these errors that happened during import to the user?
2. We should investigate reasons behind setting last_error: nil on finish, as this step hides any problems that occurred during import.

cc @lmcandrew @hdelalic

added Category:Importers devopsmanage + 1 deleted label

changed the description

mentioned in merge request !16586 (closed)

changed the description

changed milestone to %12.9

added [deprecated] Accepting merge requests label

added workflowscheduling label

added priority3 label

added workflowblocked label and removed workflowscheduling label

There is ongoing work to convert HAML based importers into Vue.js ones that might affect this issue &2208 (closed)

• This issue needs to be broken down into smaller, iterative increments. (I.e. first show the fact that the import completed with errors, then provide a summary of errors, then provide full detail.)
• Need to understand the UI/UX for showing this additional info.
• Evaluate the impact of the related issue &2208 (closed)

cc @dmoraBerlin cc @georgekoltsov cc @lmcandrew

My initial thoughts would be as part of the import, there is a log file that is generated. And at the end of the import, the log is added as part of the inventory/repo/project, or perhaps a report of actions that occurred/pass/fail during the process. I imagine having a log would be of benefit because if something is crashing consistently during repeated import, the importer can see and compare logs to track down bugs.

marked this issue as related to #30969

@georgekoltsov Is this issue a duplicate of #30969?

I think #30969 is referring to GitLab Project Import/Export and this issue is for Importers from GitHub/Bitbucket/Gitea/etc.

added Github label

changed milestone to %Next 1-3 releases

added UX label

added frontend label

added backend label

added to epic &2721

marked this issue as related to #223785 (closed)

changed the description

added sectiondev label

removed [deprecated] Accepting merge requests label

added groupimport and integrate label and removed 1 deleted label

A Premium GitLab.com SaaS customer has encountered an issue related to this.

• Zendesk (internal use only)
• Salesforce (internal use only)

The customer was experiencing issues with the BitBucket Cloud Importer, where imports would silently fail and redirect the user back to the created project, which would be empty without anything having been imported.

The following logging was checked to locate the actual cause of the import failure:

pubsub-rails-inf-gprd-*

json.meta.caller_id : Import::BitbucketController#create

json.meta.user : <username-for-user-attempting-import>

json.severity : ERROR

The importer logged the following error:

Unable to save project. Error: Failed to save the new associated push_rule. Project ID:<project-id>

If this error output was visible within the GitLab UI when the import failed, the customer likely would have figured out the problem on their own, and it also would have sped up investigation from the support team side.

added customer label

changed milestone to %Next 4-6 releases

added sectioncore platform label and removed sectiondev label