Session duration setting breaks Gitlab

Summary

Setting the session duration (minutes) setting in the GUI (Admin Area - Settings - Account and Limit Settings) to 0 will break Gitlab. After a restart you get an Error 500.

Steps to reproduce

Set the session duration (minutes) setting in the GUI (Admin Area - Settings - Account and Limit Settings) to 0 (as root user).
Restart Gitlab

Example Project

Any project.

What is the current bug behavior?

After changing the setting 'session duration' to 0 Gitlab stops working.

What is the expected correct behavior?

After changing the setting 'session duration' to 0 sessions on Gitlab should never expire. A quick fix would be to not allow a 0 in this field.

Relevant logs and/or screenshots

from production.log

Redis::CommandError (ERR invalid expire time in setex):
 lib/gitlab/request_context.rb:18:in `call'
 lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'

Results of GitLab environment info

Expand for output related to GitLab environment info

System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 12.0.0 Redis Version: 3.2.5 Git Version: 2.13.5 Sidekiq Version:5.0.4 Go Version: unknown

GitLab information Version: 9.5.4 Revision: fbffc27 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.leanfive.com HTTP Clone URL: https://gitlab.leanfive.com/some-group/some-project.git SSH Clone URL: git@gitlab.leanfive.com:some-group/some-project.git Using LDAP: yes Using Omniauth: no

GitLab Shell Version: 5.8.0 Repository storage paths:

default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

GitLab Shell Version: 5.8.0 Repository storage paths:

default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git root@zeus:/var/opt/gitlab/gitlab-rails# gitlab-rake gitlab:check SANITIZE=true Checking GitLab Shell ...

GitLab Shell version >= 5.8.0 ? ... OK (5.8.0) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 4/1 ... ok 4/2 ... ok 4/3 ... ok 4/4 ... ok 4/5 ... ok 4/6 ... ok 4/7 ... ok 4/8 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Reply by email ...

Reply by email is disabled in config/gitlab.yml

Checking Reply by email ... Finished

Checking LDAP ...

Server: ldapmain LDAP authentication... Anonymous. No bind_dn or password configured LDAP users with access to your GitLab server (only showing the first 100 results)

Checking LDAP ... Finished

Checking GitLab ...

Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 4/1 ... yes 4/2 ... yes 4/3 ... yes 4/4 ... yes 4/5 ... yes 4/6 ... yes 4/7 ... yes 4/8 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.3 ? ... yes (2.3.3) Git version >= 2.7.3 ? ... yes (2.13.5) Active users: ... 8

Checking GitLab ... Finished

Possible fixes

If you break your installation by this setting, the only way to get Gitlab up and running again is by changing the value in the database.

connect to the database

gitlab-psql -d postgres

SELECT id, application_settings.session_expire_delay FROM application_settings;

then

UPDATE application_settings SET session_expire_delay=10080 WHERE id=5;

You need to change the value of id to the id of the field that contains the 0 of the select statement.